Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add justice helm #31905

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Add justice helm #31905

merged 4 commits into from
Sep 7, 2024

Conversation

themias
Copy link
Contributor

@themias themias commented Sep 6, 2024

About the PR

Ports the justice helm from SS13 by combining the light sprites from tgstation with our base helmet sprites.

Why / Balance

I think it's silly fun, and I miss the little police siren from the secway.

The helmet requires a battery, so that will put a time limit on the noise.

I also only added it to the secdrobe and not the loadouts, to help limit the noise.
I can add it to loadouts if desired, but other officers can craft one using their helmets if they wish.

Media

justice-helm-demo.mp4

justice-helm-recipe

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Added the justice helm to the secdrobe
  • add: Added a crafting recipe for the justice helm

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

RSI Diff Bot; head commit 2b2c533 merging into 2b0f227
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Helmets/justice.rsi

State Old New Status
icon-light Added
icon Added
inhand-left Added
inhand-right Added
off-equipped-HELMET-vox Added
off-equipped-HELMET Added
on-equipped-HELMET Added

Edit: diff updated after 2b2c533

@Everturning
Copy link

the thing I dislike about this is how small the animation to show the light rotating is. its just a dot appearing on one side, then the other, which doesn't evoke the effect its going for. also, the light surrounds the wearer, but I think it would be fun to make it do the funny red rotating light thing that the nuke does when activated. cool item tho

@ps3moira
Copy link
Contributor

ps3moira commented Sep 6, 2024

Maybe use the lighting system with the emergency lights or sirens to get that spinning cop light

@Emisse
Copy link
Contributor

Emisse commented Sep 6, 2024

needs spinny light

@themias
Copy link
Contributor Author

themias commented Sep 6, 2024

I will try to add a spinny light.

Updated with spinny light. I tried adding an offset for the pointlight, but that doesn't seem to work when facing directions other than South.

@lzk228
Copy link
Contributor

lzk228 commented Sep 7, 2024

i don't really understand why a powercell is required in craft recipe if you still need a cell afterwards

@themias
Copy link
Contributor Author

themias commented Sep 7, 2024

i don't really understand why a powercell is required in craft recipe if you still need a cell afterwards

Sorry if I was unclear, I mean it "requires a cell" as in it needs power to function. It spawns with a small power cell.

@slarticodefast
Copy link
Member

Maybe remove the powercell from the recipe and make it spawn without one when crafted? That way you still need one, but can use any type except only small ones.

@EmoGarbage404
Copy link
Member

you can just make it so that the cell used for crafting is automatically inserted into the completed entity. that's what mechs do.

@themias
Copy link
Contributor Author

themias commented Sep 7, 2024

The construction graph 'store' for boards and such seems to only work with regular containers and not container slots, so I just removed the cell from the recipe.

@EmoGarbage404
Copy link
Member

container slots inherit directly from containers so i imagine it'd work the same?

@Emisse Emisse merged commit f49d83a into space-wizards:master Sep 7, 2024
13 checks passed
@themias themias deleted the add-justice-helm branch September 7, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants